[ROCm] [DOC] Update the Documentation to include ROCm Nightly Wheel support#38457
[ROCm] [DOC] Update the Documentation to include ROCm Nightly Wheel support#38457DarkLight1337 merged 11 commits intovllm-project:mainfrom
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Documentation preview: https://vllm--38457.org.readthedocs.build/en/38457/ |
mergify
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ROCm installation documentation for vLLM, including support for ROCm 7.2.1 and detailed instructions for installing specific versions, nightly builds, and commit revisions using uv and pip. It also adds a section on using the ROCm Docker image for development. Feedback was provided regarding the pip installation command for specific revisions, which incorrectly used an extra index URL instead of the direct wheel URL required for development builds.
|
Hi @tjtanaa, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
|
@gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the ROCm installation documentation to include support for ROCm 7.2.1 and provides new instructions for installing nightly builds and specific commit revisions. It also adds a guide for using ROCm Docker images in interactive mode for development. Feedback was provided regarding the automated bash commands for extracting ROCm variants; the current logic for stable releases is incorrect as the target URL structure does not match the grep pattern, making the automated approach fragile and prone to failure.
|
@gemini review |
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
|
@gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the ROCm installation documentation to include support for ROCm 7.2.1, provides instructions for installing nightly wheels and specific commit revisions, and adds a section on using the ROCm Docker image for development. Review feedback identified invalid example commit hashes that cause 404 errors and pointed out redundant sed commands in the shell scripts that should be removed for clarity.
There was a problem hiding this comment.
Code Review
This pull request updates the ROCm installation documentation to include support for ROCm 7.2.1 and introduces automated shell commands for extracting wheel variants. It also adds sections for installing nightly builds, specific commit revisions, and using the ROCm docker image for interactive development. The review feedback identifies several critical issues with the regular expressions used in the automated commands, which would fail to capture full ROCm version strings. Additionally, there is a contradiction between the instructional text and the provided pip commands that needs to be resolved, along with a suggestion to use version numbers instead of commit hashes for better user clarity.
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
github-actions
Bot
added
the
ready
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
…upport (vllm-project#38457) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> Signed-off-by: neweyes <328719365@qq.com>
…upport (vllm-project#38457) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
…upport (vllm-project#38457) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
2 participants
Purpose
The nightly ROCm wheel release starts with PR #37283
Recently we have also upgraded to ROCm 7.2.1 Torch 2.10 and Triton 3.6 in PR #38413 .
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.